[Package Request]: `ASRock.AppShop`

RokeJulianLockhart commented 2 weeks ago

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information

Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[X] I have performed a search and couldn't find this package.
[X] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information

Download Page URI	https://www.asrock.com/feature/appshop/#:~:text=Size%20%09Description-,Download,-4.26MB%20%09APP%20Shop
Publisher	ASRock
Package Name	`ASRock.AppShop`
Description	ASRock APP Shop is an all-in-one utility designed for system update and software downloading.
Package Version	2.0.0.4
Installer URI	https://download.asrock.com/Utility/Others/APPShop%28v2.0.0.4%29.zip from https://www.asrock.com/feature/appshop/dl.asp

Dragon1573 commented 2 weeks ago

Really weird ...

10:42:18 D:\...\winget-pkgs  [issues/160709 +1 ~0 -0 !] 48.044s pwsh> sudo winget install -m .\manifests\a\ASRock\AppShop\2.0.0.4\
已找到 APP Shop [ASRock.AppShop] 版本 2.0.0.4
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责，也不向第三方程序包授予任何许可证。
正在下载 https://download.asrock.com/Utility/Others/APPShop(v2.0.0.4).zip
  ██████████████████████████████  4.26 MB / 4.26 MB
已成功验证安装程序哈希
正在提取存档...
已成功提取存档
正在启动程序包安装...
已成功安装

RokeJulianLockhart commented 2 weeks ago

https://github.com/microsoft/winget-pkgs/issues/160709#issuecomment-2198413118

@Dragon1573, are you using an ASRock motherboard? I've not had that error, but I am using one:

Dragon1573 commented 2 weeks ago

@Dragon1573, are you using an ASRock motherboard?

Nope ... None of my device use this motherboard.

Is ASRock motherboard required? If it is, the issue should be closed as not planned because it will never pass the validation pipelines hosted on Microsoft Azure.

Issue should be marked with https://github.com/microsoft/winget-pkgs/labels/Blocking-Issue and https://github.com/microsoft/winget-pkgs/labels/Hardware.

RokeJulianLockhart commented 2 weeks ago

https://github.com/microsoft/winget-pkgs/issues/160709#issuecomment-2198500963

@Dragon1573, I don't know whether it does necessitate that - it was an estimate. However, this is a quite important vendor firmware updater, so it should probably be considered based upon the fact that the motherboard itself prompts the user to install it the moment that Windows is first configured - it solely being available from their website is going to cause people to accidentally install malware from similar websites higher in Google's search rankings.

Dragon1573 commented 2 weeks ago

Do you have any other devices with non-ASRock baseboard? Could you please check if this baseboard is required for running ASRock.AppShop?

[!NOTE]

My device is a laptop bought from HUAWEI. Some packages (such as Huawei.AppGallery and Huawei.HuaweiMobileCloud) are integrated to the initial OS image and support features only available for HUAWEI hardware.

In your situation, it would be better integrate to the OS image than asking users to install themselves. Or, provide the official link directly to users instead of asking users to search themselves.

RokeJulianLockhart commented 2 weeks ago

https://github.com/microsoft/winget-pkgs/issues/160709#issuecomment-2198558234

@Dragon1573, I think you quite severely underestimate what would be bureaucratically necessary to integrate this into Windows, and why that would be wholly undesirable - generally the more modular an OS, the better. Irrespective, that shan't occur.

I do have another device with the exact same baseboard, and it indeed installs, but why do you ask - what does that demonstrate?

Dragon1573 commented 2 weeks ago

Could you launch App Shop on that non-ASRock baseboard?

I do able to submit a manifest for this package, but I think it will mostly fail during validation.

@stephengillie , this package seems hard depends on a specific hardware (baseboard), how can we dig deeper? :pray:

I created a manifest and validated with Tools/SandboxTest.ps1, it can be successfully installed but unable to launch. Should we reject this package?

RokeJulianLockhart commented 2 weeks ago

https://github.com/microsoft/winget-pkgs/issues/160709#issuecomment-2198834409

@Dragon1573, I've no non-ASRock baseboard to evaluate this on. Is there no way to perform manual validation? I ask because I've recently seen myriad reports of users falling for phishing URIs when attempting to download the installer for this package (it's a fault of ASRock's hideous SEO and bad website design) so having it on WinGet would make it easier for me to recommend it.

Dragon1573 commented 2 weeks ago

Currently, the PR mentioned above pass the automatic validation. Moderators of this repository will perform manual validation with this package on Azure VMs.

Currently no responses from them. Patience are needed.

stephengillie commented 2 weeks ago

Unfortunately, we're not able to satisfy the hardware requirement.

Dragon1573 commented 2 weeks ago

@RokeJulianLockhart, the hardware requirements is proved. I think we can closed this issue as "not planned".

microsoft / winget-pkgs