microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.52k stars 4.42k forks source link

[Package Request]: `FilesCommunity.Files.Preview` #166364

Open RokeJulianLockhart opened 1 month ago

RokeJulianLockhart commented 1 month ago

How can we help?

I would like someone else to build the manifest.

Please read and ensure the following

Please provide the following information

Download Page URI https://files.community/download
Publisher https://github.com/files-community
Package Name
Static FilesCommunity.Files.Preview
Vanity Files - Preview per https://github.com/microsoft/winget-pkgs/issues/150390#issuecomment-2081062536:~:text=The%20name%20should%20show%20as%20Files%20%2D%20Preview.
Description
Introducing Files, the ultimate file manager for Windows. With its sleek and intuitive design, navigating through your files and documents has never been easier.
Package Version 3.6.0.0, from https://github.com/files-community/Files/releases/tag/v3.6 (per https://github.com/files-community/Files/releases/latest).
Installer URI https://cdn.files.community/files/preview/Files.Package_3.6.0.0_Preview_Test/Files.Package_3.6.0.0_x64_arm64_Preview.msixbundle
  1. Relates to https://github.com/microsoft/winget-pkgs/issues/150390#issuecomment-2068290158.
  2. Remediates https://github.com/files-community/Files/issues/11380#issue-1591954869.
Dragon1573 commented 1 month ago

[!NOTE]

https://github.com/microsoft/winget-pkgs/labels/Blocking-Issue https://github.com/microsoft/winget-pkgs/labels/Area-External https://github.com/microsoft/winget-pkgs/labels/Interactive-Only-Installer

*.appinstaller of this package is currently not supported by winget.exe, since it can't be installed unattendedly. Also the "classic installer" is only provided for stable version.

This issue should be closed as "not planned".

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273528233

@Dragon1573:

  1. Does an issue for supporting .AppInstaller packages exist?

    https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273650001

  2. I did ask How do APPX, MSIX/MSIXBundle, and AppInstaller packages differ? at SE SU prior to filing this, but I didn't receive any responses, so I wasn't aware.

  3. I'll try to request a standard MSIX package too.

    https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273633455

RokeJulianLockhart commented 1 month ago

I'll try to request a standard MSIX package too.

@Dragon1573, I've filed https://github.com/files-community/Files/issues/15973#issue-2453655841 to hopefully bypass WinGet's lack of support for .AppInstaller files.

Josh65-2201 commented 1 month ago

I have already given a link for preview builds https://github.com/microsoft/winget-pkgs/issues/150390#issuecomment-2081062536

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273610132

@Dragon1573, I've filed https://github.com/microsoft/winget-cli/issues/4711#issue-2453673163 for support for the .AppInstaller format, because none existed.

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273649589

Thanks, @Josh65-2201. I'll update it with that:

<a href="https://cdn.files.community/files/preview/Files.Package_3.5.6.0_Preview_Test/Files.Package_3.5.6.0_x64_arm64_Preview.msixbundle">https://cdn.files.community/files/preview/Files.Package_3.5.6.0_Preview_Test/Files.Package_3.5.6.0_x64_arm64_Preview.msixbundle</a>
RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273651129

@Josh65-2201, I'm going to revert the request to include the .AppInstaller package:

> ```MD > https://files.community/appinstallers/Files.preview.appinstaller > ```

...per https://github.com/files-community/Files/issues/15973#issuecomment-2273648537:

We don’t offer standalone MSIX packages because they require specific dependencies to be installed beforehand, and we can’t provide the support needed for any confusion this might cause.

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273528233

@Dragon1573, https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273660318 has been reverted per https://github.com/files-community/Files/issues/15973#issuecomment-2273719750, so the installer URI is now an .MSIXBundle package.

Dragon1573 commented 1 month ago

It seems the *.msixbundle requires extra configurations.

Josh65-2201 commented 1 month ago

Based on the PR your missing the dependencies and the arm64 version that Files supports. You can see the one for stable https://github.com/microsoft/winget-pkgs/pull/150504

Dragon1573 commented 1 month ago

Dependencies and arm64 entries are included in the manifest.

florelis commented 1 month ago
  1. I did ask How do APPX, MSIX/MSIXBundle, and AppInstaller packages differ? at SE SU prior to filing this, but I didn't receive any responses, so I wasn't aware.

@RokeJulianLockhart,

.appx and .msix are basically the same. You can change the extension from one to the other and things will generally work. Difference is that .appx is older. Older versions of the OS don't know MSIX (I think those are already out of support), and there are probably features that are only supported in MSIX and not APPX, but the package format is the same.

A bundle (either MSIX or APPX) contains a collection of individual packages. Those can be variations of the same package, just for different architectures. Or they can be resource packages with the strings/assets for different locales.

A .appinstaller file is an XML file that helps the OS manage auto-updates and dependencies for an MSIX package/bundle. It lists a URI for a main package and its dependencies, so that the OS can install the dependencies before the main package. It also lists a URI where a new version of the .appinstaller file can be found, and the OS can use that to check for updates.

Without changes to winget, you can already add a package for which you have a .appinstaller by just opening it in a text editor and extracting the package URI to use in winget.

*.appinstaller of this package is currently not supported by winget.exe, since it can't be installed unattendedly

@Dragon1573, It isn't true that it cannot be installed unattended (but it's true that winget doesn't support it). You can do Add-AppPackage -AppInstallerFile <path> in PowerShell, or use the API PackageManager.AddPackageByUriAsync()

RokeJulianLockhart commented 1 month ago

https://github.com/microsoft/winget-pkgs/issues/166364#issuecomment-2273966067

@florelis, that's brilliantly comprehensive. Thank you.

If you'd rather not submit one yourself, I've added that as an answer to the cited SU question:

https://superuser.com/revisions/1851577/2#:~:text=Paraphrased%2C%20github.com/microsoft/winget%2Dpkgs/issues/166364%23issuecomment%2D2273966067%20explains:,Alternatively%2C%20use%20the%20API%20%22PackageManager.AddPackageByUriAsync()%22

microsoft-github-policy-service[bot] commented 3 weeks ago

Hello @RokeJulianLockhart,

This package appears to require user interaction to install.

This package is blocked until support for interactive installer search filtering is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/interactiveOnlyInstall