Closed SoftCreatR closed 4 years ago
Here's the commit with the fixed files: https://github.com/SoftCreatR/winget-pkgs/commit/0ecaf9679725921d2f63f37c676c273f6d636872
There are also significantly more that are using us-ascii
encoding
$ find manifests/ -type f -exec file --mime {} \; | grep "charset=us-ascii" | wc -l
553
Even more than are using UTF-8
$ find manifests/ -type f -exec file --mime {} \; | grep "charset=utf-8" | wc -l
156
I think requiring UTF-8 encoding is probably the best way forward.
I just found/fixed these, because they cannot be read on a linux machine. Good examples are https://wingetit.com and https://winstall.app where affected manifests are not listed. On https://www.winget.it I already fixed it, regardless of my PR.
While improving our automation process, i stumbled upon a bunch of files, that seem to be wrong encoded (UTF16). On Windows, this doesn't seem to be a big problem, but on Linux, these files are garbled with asian nonsense, e.g.:
List of affected files:
I already wrote something to fix this, however i'm limited to one file per PR, so i will have to create 51 pull requests.
@KevinLaMS @denelon I would prefer to create a branch where i push all fixed files at once. When done, I would link it so you could grab and merge it. Or is there no way around the 1 file / PR limitation?