microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.76k stars 4.57k forks source link

[Package Issue]: gnome.Dia - WinGet Forgets Installed Version of gnome.Dia Immediately After Upgrade #173832

Open Lonniebiz opened 2 months ago

Lonniebiz commented 2 months ago

Please confirm these before moving forward

Category of the issue

Other

Brief description of your issue

WinGet forgets the installed version of gnome.Dia immediately after upgrading, leading to unnecessary repeated upgrades in subsequent runs.

Steps to reproduce

  1. Open PowerShell
  2. Run winget install dia --scope machine --source winget to install Dia if not already installed
  3. After installation, run winget upgrade --all --include-unknown
  4. Observe that gnome.Dia shows "Unknown" in the Version column, but has an "Available" version listed
  5. Allow the upgrade to proceed and complete successfully
  6. Immediately run winget upgrade --all --include-unknown again
  7. Notice that gnome.Dia still shows as "Unknown" in the Version column and is again offered for upgrade to the same version that was just installed

Actual behavior

Winget successfully upgrades gnome.Dia to the latest available version. However, it immediately "forgets" this version information. In subsequent runs, even immediately after an upgrade, the Version column remains "Unknown" for gnome.Dia. This results in winget repeatedly offering to upgrade gnome.Dia to the same version in every run, creating a loop of unnecessary upgrades.

Expected behavior

After a successful upgrade, winget should remember and correctly display the installed version of gnome.Dia. Subsequent winget upgrade commands should not offer to upgrade gnome.Dia unless a newer version is actually available. The Version column should show the correct installed version, and gnome.Dia should only be listed for upgrade when there's a genuine new version available.

Environment

Windows Package Manager v1.8.1911
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.4894
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

Screenshots and Logs

No response

Dragon1573 commented 2 months ago

image

This nullsoft installer does not write version information to the Windows Registry. Maybe it's the reason.

Dragon1573 commented 2 months ago

[!NOTE]

Although I add AppsAndFeaturesEntries to the manifest, there's still no DisplayVersion and Publisher information written to Windows Registry.

AppsAndFeaturesEntries:
- DisplayName: Dia
  DisplayVersion: 0.97.2
  Publisher: gnome
stephengillie commented 2 months ago

It's the "upgrade always available" situation again. https://github.com/microsoft/winget-pkgs/issues/173833#issuecomment-2356158107