[Package Issue]: Perforce.P4V

mikhailmaximov commented 1 month ago

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

winget reads version of the installed package incorrectly and suggests to upgrade it.

Steps to reproduce

From the PowerShell command line

> winget install Perforce.P4V
...
> winget upgrade
Name                 Id                       Version  Available    Source
--------------------------------------------------------------------------
Helix Core Apps      Perforce.P4V             242.42.4 242.263.4463 winget

Actual behavior

winget is asking to upgrade freshly installed package because of incorrect read of its version

Expected behavior

winget should not list Perforce.PV4 as one with update available

Environment

Windows Package Manager v1.8.1911
Windows: Windows.Desktop v10.0.22631.4169
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

Screenshots and Logs

WinGet.log

> winget list | Select-String -SimpleMatch "Microsoft.VCRedist.2015+.x64","Perforce","----","Name  "
Name                                   Id                                     Version               Available    Source
-----------------------------------------------------------------------------------------------------------------------
Helix Core Apps                        Perforce.P4V                           242.42.4              242.263.4463 winget
Microsoft Visual C++ 2015-2022 RedistΓÇª Microsoft.VCRedist.2015+.x64           14.40.33810.0                      winget

> winget upgrade
Name                 Id                       Version  Available    Source
--------------------------------------------------------------------------
Helix Core Apps      Perforce.P4V             242.42.4 242.263.4463 winget
Cisco Webex Meetings Cisco.CiscoWebexMeetings 43.10.0  44.10.0.88   winget
2 upgrades available.

> winget upgrade Perforce.P4V
Found Helix Core Apps [Perforce.P4V] Version 242.263.4463
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.VCRedist.2015+.x64
Downloading https://www.perforce.com/downloads/perforce/r24.2/bin.ntx64/p4vinst64.msi
  ██████████████████████████████   159 MB /  159 MB
Successfully verified installer hash
Starting package install...
Successfully installed

> winget upgrade
Name                 Id                       Version  Available    Source
--------------------------------------------------------------------------
Helix Core Apps      Perforce.P4V             242.42.4 242.263.4463 winget
Cisco Webex Meetings Cisco.CiscoWebexMeetings 43.10.0  44.10.0.88   winget
2 upgrades available.

a-mnich commented 3 weeks ago

While the package is more or less marketed under the current PackageVersion: 242.263.4463 a different version is written into the AppsAndFeaturesEntries DisplayVersion: 242.42.4 (see current manifest and MarketingVersion vs PackageVersion)

For solving this "upgrade always available" issue either AppsAndFeaturesEntries need to be added to the manifest or the PackageVersion needs to be adapted to match the actual DisplayVersion.

Website: