XavierGeerinck commented 3 years ago

Package Requested

[x] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[x] I have performed a search and couldn't find this package.
[ ] I think there is a new version available and I have provided the URL.

Manifest:

Fill out as much of the manifest metadata you can:

PackageIdentifier:  PyEnv.PyEnv # publisher.package format (example: "Microsoft.WindowsTerminal")
PackageVersion:     2.0.1.0 # version number format x.y.z.a (example: "1.6.10571.0")
PackageLocale:      en-US # meta-data locale (example: "en-US")
Publisher:          PyEnv # publisher name (example: "Microsoft Corporation")
PackageName:        PyEnv   # package name (example: "Windows Terminal")
License:            MIT # package license (example: "MIT")
ShortDescription:   Simple Python version management # package description (example: "The new Windows Terminal")
Installers: 
 - Architecture:     / # installer architecture (example: "x64")
   InstallerType:    Source Code + Path variable # installer type (example: "msix")
   InstallerUrl:     https://github.com/pyenv/pyenv/releases/tag/v2.0.1 # installer URL (should be https://)
   InstallerSha256:  /# SHA256 hash calculated from installer
ManifestType: singleton
ManifestVersion: 1.0.0

Note: This was started but never finished? https://github.com/pyenv-win/pyenv-win/issues/134

lychichem commented 3 years ago

Sorry, up till now the package should be an installer, source code or zip files are not supported. Maybe you need to wait for quite a long time.

kirankotari commented 3 years ago

@XavierGeerinck @lychichem is there any docs for me to generate exe or msi file for this (simple way) for my reference.

PackageIdentifier:  PyenvWin.PyEnv
PackageVersion:     2.64.8
PackageLocale:      en-US
Publisher:          PyenvWin
PackageName:        PyEnv
License:            MIT
ShortDescription:   Simple Python version management
Installers: 
 - Architecture:     x64
   InstallerType:    Source Code + Path variable # installer type (example: "msix") # Need help: didn't understood what to add in these variables
  # [System.Environment]::SetEnvironmentVariable('PYENV',$env:USERPROFILE + "\.pyenv\pyenv-win\","User")
  # [System.Environment]::SetEnvironmentVariable('PYENV_HOME',$env:USERPROFILE + "\.pyenv\pyenv-win\","User")\
  # [System.Environment]::SetEnvironmentVariable('path', $env:USERPROFILE + "\.pyenv\pyenv-win\bin;" + $env:USERPROFILE + "\.pyenv\pyenv-win\shims;" + [System.Environment]::GetEnvironmentVariable('path', "User"),"User")
   InstallerUrl:     https://github.com/pyenv-win/pyenv-win/releases/tag/v2.64.8
   InstallerSha256:  /# SHA256 hash calculated from installer
ManifestType: singleton
ManifestVersion: 1.0.0

lychichem commented 3 years ago

@kirankotari Even if you can generate an installer for pyenv, it may still be blocked due to dependency on other packages (python). And I don't know where to find a doc for building msi...

XavierGeerinck commented 3 years ago

Would be really nice to still be able to build this as this is useful for a lot of people (I linked the other issue here as well).

XavierGeerinck commented 3 years ago

Note: https://github.com/pyenv-win/pyenv-win#get-pyenv-win shows how to install it. It is already supported on Chocolatey

ItzLevvie commented 3 years ago

cc @kirankotari @XavierGeerinck: seems like you'll have to wait for https://github.com/microsoft/winget-cli/issues/140.

kirankotari commented 3 years ago

@kirankotari Even if you can generate an installer for pyenv, it may still be blocked due to dependency on other packages (python). And I don't know where to find a doc for building msi...

No, This package is written in visual basic and batch which are window inbuilt languages. No external package dependency.

lychichem commented 3 years ago

@kirankotari Even if you can generate an installer for pyenv, it may still be blocked due to dependency on other packages (python). And I don't know where to find a doc for building msi...

No, This package is written in visual basic and batch which are window inbuilt languages. No external package dependency.

kirankotari commented 3 years ago

@lychichem you are referring to a wrong link which is not for windows system. For pyenv-win which is pyenv for windows doesn't have dependency as such.

https://github.com/pyenv-win/pyenv-win https://github.com/pyenv/pyenv/issues/62

XavierGeerinck commented 3 years ago

https://code.visualstudio.com/docs/python/environments also lists pyenv as an important tool

@kirankotari any possibility of being able to create an MSI installer for it?

As far as I can see, GitHub CLI has a workflow for it!

GitHub Workflow: https://github.com/cli/cli/blob/trunk/.github/workflows/releases.yml#L133
- It utilizes go-msi (https://github.com/mh-cbon/go-msi)
- Which in turn implements WIX

Trenly commented 1 year ago

@Msftbot .zip

devmcp commented 1 year ago

Are there any updates on this? It would be great to have!

fsdrw08 commented 1 year ago

any updates about this issue?

Trenly commented 2 months ago

Although Zip packages have been unblocked, the installation instructions specify additional environment variables that need to be set other than just the PATH environment variable. This means that until an msi or exe installer is made available, WinGet still has no way to properly install the package

microsoft / winget-pkgs

Package: PyEnv #17988

Package Requested