search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.57k stars 4.46k forks source link

[Bug]: Corsair iCue 4.17.244 requires elevation for install/uninstall but doesn't request it #36230

Open Clockwork-Muse opened 2 years ago

Clockwork-Muse commented 2 years ago

Brief description of your issue

Attempting to install Corsair iCue from a non-elevated command prompt fails due to insufficient permissions, and it does not request elevation (unlike, say, git)

Steps to reproduce

winget install --id Corsair.iCUE.4
Found CORSAIR iCUE 4 Software [Corsair.iCUE.4] Version 4.17.244
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://downloads.corsair.com/Files/CUE/iCUESetup_4.17.244_release.msi
  ██████████████████████████████   792 MB /  792 MB
Successfully verified installer hash
Starting package install...
Installer failed with exit code: 1603

Expected behavior

The package requests elevation, if necessary.

Actual behavior

The package fails to install WinGet-Corsair.iCUE.4.4.17.244-2021-11-26-18-21-47.977.log

Environment

Windows Package Manager v1.1.12986
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1348
Package: Microsoft.DesktopAppInstaller v1.16.12986.0
OfficialEsco commented 2 years ago

We cannot resolve this at the moment

  1. winget version 1.2+ still does not respect this field (Hopefully its supported in winget version 1.2) https://github.com/microsoft/winget-cli/issues/1537 Milestone: v1.2-Client
  2. wingetcreate does not support manifest version 1.1.0 and removes the unknown fields https://github.com/microsoft/winget-create/issues/139
  3. YamlCreate does not support manifest version 1.1.0 yet but will once this PR gets merged https://github.com/microsoft/winget-pkgs/pull/35735

This PR should remain open and should probably get a new tag so we can fix it once those 3 requirements are resolved

Trenly commented 2 years ago

winget version 1.2+ still does not respect this field (Hopefully its supported in winget version 1.2)

I've added the field and requested a merge on #35735 so that hopefully this package will work once the next winget version is released

denelon commented 2 years ago

I was testing this, and I think I found another bug:

winget-bug
OfficialEsco commented 2 years ago

Did you see that in Windows 10 or Windows 11? I've seen a very similar popup randomly on multiple installers when validating packages on Windows 11, however there you just click Not now and it installs.

denelon commented 2 years ago

It was on Windows 11. We've seen this before in the Sandbox, but we have an idea what might have caused it on the primary OS.