search

microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.68k stars 4.52k forks source link

Android SDK Platform-Tools #4082

Open Weirdo1312 opened 4 years ago

Weirdo1312 commented 4 years ago

Package Requested

Manifest:

Fill out as much of the manifest as you can:

Id: string # publisher.package format
Publisher: Google # the name of the publisher
Name: Android SDK Platform-Tools # the name of the application
Version: 30.0.4 # version numbering format
License: developer.android.com/license # the open source license or copyright
InstallerType: exe (standalone, no installer) # enumeration of supported installer types (exe, msi, msix, inno, wix, nullsoft, appx)
Installers:
  - Arch: string # enumeration of supported architectures
    Url: https://dl.google.com/android/repository/platform-tools_r30.0.4-windows.zip # path to download installation file
    Sha256: string # SHA256 calculated from installer
# ManifestVersion: 0.1.0
denelon commented 4 years ago

@barfin is this a duplicate of #3680?

Weirdo1312 commented 4 years ago

@barfin is this a duplicate of #3680?

No, Android SDK platform tools are "adb" and "fastboot" command line tools for interacting with android phones with usb debugging enabled like flashing some rom or recovery or rebooting into a specific img or and other good stuff it's not for making android apps like android studio is

ptanmay143 commented 4 years ago

Package Requested

Manifest:

Fill out as much of the manifest as you can:

Id: string # publisher.package format
Publisher: Google # the name of the publisher
Name: Android SDK Platform-Tools # the name of the application
Version: 30.0.4 # version numbering format
License: developer.android.com/license # the open source license or copyright
InstallerType: exe (standalone, no installer) # enumeration of supported installer types (exe, msi, msix, inno, wix, nullsoft, appx)
Installers:
  - Arch: string # enumeration of supported architectures
    Url: https://dl.google.com/android/repository/platform-tools_r30.0.4-windows.zip # path to download installation file
    Sha256: string # SHA256 calculated from installer
# ManifestVersion: 0.1.0

The installer type is not exe. It is actually a zip which needs to be extracted and added to the PATH environment variable. Till winget gets zip install support, I don't think we can get Android platform tools being packaged here.

ghost commented 3 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

Weirdo1312 commented 3 years ago

@denelon please remove "Needs feedback" tag

MattBDev commented 3 years ago

This should have the label ".zip" and "Blocking-Issue"

denelon commented 3 years ago

https://github.com/microsoft/winget-cli/issues/859

rollingmoai commented 2 years ago

microsoft/winget-cli#859

Shouldn't it be https://github.com/microsoft/winget-cli/issues/140? (it's not an installer inside)

denelon commented 2 years ago

We will have support for a portable app:

first, then we will implement:

which will include:

j2ghz commented 2 years ago

We will have support for a portable app:

first, then we will implement:

which will include:

These seem to be implemented, is this unblocked now?

vedantmgoyal9 commented 2 years ago

cc @Trenly

Trenly commented 2 years ago

We will have support for a portable app:

first, then we will implement:

which will include:

These seem to be implemented, is this unblocked now?

Not exactly. They have been implemented, but not yet released. I can create the manifest for it, but it won’t be able to be merged until the Winget Client version 1.4 is released to stable and about 50% of users have updated to the new version

bet4it commented 1 year ago

Could it be implemented now?

sitiom commented 1 year ago
denelon commented 1 year ago
Trenly commented 1 year ago

Based on the discussion in the linked PR, this is a Zipped binary file and not just a portable EXE. Because of the way symlinks work, this is now blocked by https://github.com/microsoft/winget-cli/issues/2711

cc @denelon for labeling with Zipped Binary