[Package Issue]: FreeCAD.FreeCAD

agowa commented 2 years ago

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

Not silently installing. It opens a gui

Steps to reproduce

winget upgrade FreeCAD.FreeCAD

Actual behavior

Opens the installer GUI and waits for user input

Expected behavior

silently installing

Environment

[winget --info]
Windows Package Manager (Preview) v1.4.2161-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.25188.1000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.2161.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs

No response

Trenly commented 1 year ago

@agowa338 - Is this issue still happening?

Clockwork-Muse commented 1 year ago

@Trenly - It no longer requests interaction on install (other than an elevation prompt, despite installing for the current user only), but it now requires user interaction on uninstall:

Furthermore, uninstall isn't "clean". It leaves behind entries in the "Installed apps" and "Programs and Features" menus: The "Installed apps" entry is annoying, because attempting to uninstall it from there results in an error window:

Upgrading in particular is problematic, because the uninstallation is considered "complete" once the uninstaller window appears, meaning there are potential races between install and uninstall. Currently each version is getting its own directory for at least some files, so it might not be a complete problem, but it's at least worrying.

Uninstall log: WinGet-2023-09-11-20-42-49.873.log

winget --info
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.2134
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

pilcherd commented 9 months ago

This is still happening.

Worse, the uninstall UI doesn't block the install process, and so you can be left with a junk install:

Uninstall 0.21.1
UI shows uninstall Window (!!!!!) and since I didn't click it, the next installer runs
0.21.2 install shows ok and everything complete.
I ok the uninstall dialog, but that is a big mistake, since this is a dumb installer (not an MSI) that does no reference counting and has the files in a 0.21 folder. So 0.21.1 removes the 0.21 install and I'm left with nothing installed, a broken link in add-remove programs and a winget that thinks something is installed and not installed. I.e. it won't install but cannot uninstall.

microsoft / winget-pkgs