microsoft / winget-pkgs

The Microsoft community Windows Package Manager manifest repository
MIT License
8.74k stars 4.56k forks source link

[Package Issue]: FreeCAD.FreeCAD #77958

Open agowa opened 2 years ago

agowa commented 2 years ago

Please confirm these before moving forward

Category of the issue

Installation issue.

Brief description of your issue

Not silently installing. It opens a gui

Steps to reproduce

winget upgrade FreeCAD.FreeCAD

Actual behavior

Opens the installer GUI and waits for user input

Expected behavior

silently installing

Environment

[winget --info]
Windows Package Manager (Preview) v1.4.2161-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.25188.1000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.2161.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Screenshots and Logs

No response

Trenly commented 2 years ago

@agowa338 - Is this issue still happening?

Clockwork-Muse commented 1 year ago

@Trenly - It no longer requests interaction on install (other than an elevation prompt, despite installing for the current user only), but it now requires user interaction on uninstall: image image

Furthermore, uninstall isn't "clean". It leaves behind entries in the "Installed apps" and "Programs and Features" menus: image image The "Installed apps" entry is annoying, because attempting to uninstall it from there results in an error window: image

Upgrading in particular is problematic, because the uninstallation is considered "complete" once the uninstaller window appears, meaning there are potential races between install and uninstall. Currently each version is getting its own directory for at least some files, so it might not be a complete problem, but it's at least worrying.

Uninstall log: WinGet-2023-09-11-20-42-49.873.log

winget --info
Windows Package Manager v1.5.2201
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.2134
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.2201.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
pilcherd commented 10 months ago

This is still happening.

Worse, the uninstall UI doesn't block the install process, and so you can be left with a junk install:

luzpaz commented 3 days ago

Perhaps this is fixed in 1.0 ?
https://github.com/microsoft/winget-pkgs/issues/192392