Video capture device id isn't respected

microsoft / winrtc

The WinRTC project hosts everything needed to build apps with interoperable real time communications for modern Windows. It brings the power of WebRTC to modern Windows apps written in C#, C++ and VB. WinRTC enables real-time voice calling, video chat and data functionality (file transfer etc.) with web browsers via WebRTC.

346 stars 68 forks source link

Video capture device id isn't respected #131

Open FrayxRulez opened 3 years ago

FrayxRulez commented 3 years ago

Describe the bug Currently, VideoCaptureWinRTInternal::StartCapture chooses which device to use from capability.profile_id. The problem is that this id is never assigned for capabilities retrieved from VideoMediaController. Thus, if the user has multiple cameras connected, only the first one gets selected.

FrayxRulez commented 3 years ago

In addition to this, capabilities from device profile, get as profile_id the id of the actual VideoProfile, and I'm 99% sure that this is wrong as well. Unfortunately I don't have any device supporting profiles to test myself.