search

microsoft / winsdkfb

The Windows SDK for Facebook allows developers to provide Facebook integration for Windows Apps.
Other
182 stars 101 forks source link

C# Code Generator generates variable names with illegal character #213

Open osaatcioglu opened 8 years ago

osaatcioglu commented 8 years ago

FBUser.xml generates variables with a valid character in an English language Windows 10 machine. However; my customer is using Turkish language Windows 10 machine to compile the app and the variable names are capitalized based on Turkish language. And, this creates an invalid character for id in FBUser because of Turkish I problem as described in here http://haacked.com/archive/2012/07/05/turkish-i-problem-and-why-you-should-care.aspx/

This is the generated code after FBUser.xml (https://github.com/Microsoft/winsdkfb/blob/master/winsdkfb/winsdkfb/winsdkfb.Shared/FBUser.xml) // .... property Platform::String^ İd { Platform::String^ get(); void set(Platform::String^ value); }

the xml file is encoded with UTF-8. And, I tried to find a way to change the common culture in Visual Studio. But, I couldn't find a way.

Please let know if this is a bug or is there something that I need to change? Thanks.

khouzam commented 8 years ago

We need to look into this, if there's a way for the generation not to be localized.