search

microsoft / wopi-validator-core

A tool to test and validate server-side WOPI implementations
MIT License
42 stars 34 forks source link

Determine the fate of the proof key tests #22

Closed tylerbutler closed 1 year ago

tylerbutler commented 6 years ago

The proof key tests can’t work as-is because there’s no signing key. We can disable the tests, but I think a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.

raffis commented 5 years ago

Should be disabled for now, it is irritating that those tests fail even if implemented correctly.

thomaslevesque commented 4 years ago

a better fix would be to provide a dummy WOPI discovery XML file in this repo and expose a key there. It could be a fixed key since it’s only used for testing.

👍

That's what I did in my working copy to be able to pass those tests. Most of the necessary code is already there, it just needs a key.

thomaslevesque commented 4 years ago

I'd like to emphasize how important it is to be able to run these tests locally. We can't use the test WOPI environment to debug on the local machine, so being able to use wopi-validator-core is extremely helpful. There's very little work needed to make the proof key tests work; I can send a PR if you like.

tylerbutler commented 4 years ago

PRs are welcome.

thomaslevesque commented 4 years ago

@tylerbutler did you see my PR (#86)? I didn't receive any feedback

sergiypopovych7576 commented 3 years ago

@thomaslevesque @tylerbutler Hi guys, is there any progress on this? I see we have a PR, but it was not reviewed

Also, maybe we can have a small update in Readme to describe how to run proof key tests?

mikeebowen commented 2 years ago

@tylerbutler @thomaslevesque , there hasn't been an update on this in quite a while. Are there plans to merge this? Working tests for the proof keys would be very helpful. Thanks!

v-stefansi commented 1 year ago

We are in the process of closing this GitHub repository. This issue has been moved to the CSPP team ADO backlog list for consideration. If you would like to follow up or provide more information, please reach out to csppteam@microsoft.com.

mikeebowen commented 1 year ago

@v-stefansi

Where will this repository be hosted after it has been closed?

v-stefansi commented 1 year ago

Hi Michael,

We are no longer going to be hosting a GitHub repository for CSPP. Please reach out to @.**@.> for issues/concerns/suggestions regarding the Validator or other CSPP-related issues.

Thanks,

Stefan Sierakowski Program Manager Microsoft Cloud Storage Partner Program

From: Michael Bowen @.> Sent: Monday, January 30, 2023 8:21 AM To: microsoft/wopi-validator-core @.> Cc: Stefan Sierakowski (Synaxis Corporation) @.>; Mention @.> Subject: Re: [microsoft/wopi-validator-core] Determine the fate of the proof key tests (#22)

@v-stefansihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fv-stefansi&data=05%7C01%7Cv-stefansi%40microsoft.com%7C20f93218353e4da4b94608db02de0337%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638106924784866485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SS%2FBtNtRkyn9l2dQv6o7IVxUd2rhAJAiuKhQV8qH4BI%3D&reserved=0

Where will this repository be hosted after it has been closed?

- Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fwopi-validator-core%2Fissues%2F22%23issuecomment-1408929284&data=05%7C01%7Cv-stefansi%40microsoft.com%7C20f93218353e4da4b94608db02de0337%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638106924784866485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FPzfy9eK%2Bd%2Fl7BayKg9aLWw%2Fnfw4CucYAppkTC7wJSw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYR2OQ6NO53SCINF4GRONBDWU7S7XANCNFSM4FMLTNPQ&data=05%7C01%7Cv-stefansi%40microsoft.com%7C20f93218353e4da4b94608db02de0337%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638106924784866485%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LhhFzQSp5cEaQP6CqrEHGYG3zxfK8ieuopFxGHSKpNI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

mikeebowen commented 1 year ago

@v-stefansi ,

The contacts in your post are blocked out. Can you please re-post.

Will this repo be hosted somewhere else publicly, e.g. Azure DevOps, GitLab, etc.?