this fixes the transcript bug impacting chrome and firefox. However, this is a temporary fix. I'm nearly finished with the long-term fix in an internal repository that will live directly in azuremediaplayer.js . We'll "back out" this change when a) the fix in azuremediaplayer.js is available and b) when we upgrade to a version of their library that contains the fix
Where should the reviewer start?
n/a. this is a small change. FYI: please ignore the vttcue.js change . that's an external file we're temporarily adding to our repo
How can this be manually tested? (brief repro steps)
Try using transcripts in a recent version of firefox or chrome
I'll share URLs with and without the fix later today. However, these will only be available on corpnet
What are the relevant TFS items? (list id numbers)
100880
Definition of done:
[x] Title of the pull request is clear and informative
[x] Add pull request hyperlink to relevant TFS items
[x] For large or complex change: schedule an in-person review session
[ ] This change has appropriate test coverage
Reminders BEFORE merging
Get at least two approvals
If you're merging from a feature branch into the development branch then "flatten" or "squash" commits
If merging from the development branch into master (or porting changes from upstream) then use github's UI to get review feedback, but use the git command line interface to complete the actual merge.
Reminders AFTER merging
Delete the remote feature branch
Resolve relevant TFS items
(reverse merge) If you merged from the development branch into master then check to see if there are any changes in master that can be merged down to the development branch (like hotfixes, etc). In this case, use github's UI for feedback and the git command line interface for the actual merge.
What does this PR do? Please provide some context
this fixes the transcript bug impacting chrome and firefox. However, this is a temporary fix. I'm nearly finished with the long-term fix in an internal repository that will live directly in azuremediaplayer.js . We'll "back out" this change when a) the fix in azuremediaplayer.js is available and b) when we upgrade to a version of their library that contains the fix
Where should the reviewer start?
n/a. this is a small change. FYI: please ignore the vttcue.js change . that's an external file we're temporarily adding to our repo
How can this be manually tested? (brief repro steps)
Try using transcripts in a recent version of firefox or chrome I'll share URLs with and without the fix later today. However, these will only be available on corpnet
What are the relevant TFS items? (list id numbers)
100880
Definition of done:
Reminders BEFORE merging
Reminders AFTER merging