microsoft / xblock-azure-media-services

xblock-azure-media-services
Other
14 stars 19 forks source link

Restrict share option only to staff #64

Closed prabhanshu closed 5 years ago

prabhanshu commented 5 years ago

What does this PR do? Please provide some context

Acceptance Criteria
  1. An author can choose to make the share button available to 'staff only' to make the video anonymous, but will no longer have the option to set the "Share the video' with 'All' option.
  2. The dropdown option called 'staff only' is renamed to 'On'.
  3. The 'Share the video' dropdown options will be : 'Off (Default)' and 'On'
  4. The share button continues to provides an embeddable URL and code so staff/authors can embed the experience into a site that supports iFrames.
  5. When clicking the Share button from the video player, this section is completely remove" The player is governed by this license. Please read it. By copying or displaying this player, you agree to abide by this license. If you do not agree, do not copy or display the player.
  6. Definition of Done is met.

Where should the reviewer start?

How can this be manually tested? (brief repro steps and corpnet-URL with change)

What are the relevant TFS items? (list id numbers)

Definition of done:

Reminders DURING merge

  1. If you're merging from a short-term (feature) branch into a long-term branch (like dev, release, or master) then "Squash and merge" to keep our history clean.
  2. If merging from two longterm branches (like cherry picks from upstream, dev to release, etc) then "Create merge commit" to preserve individual commits.
manikarthikk commented 5 years ago

can you update the title

prabhanshu commented 5 years ago

@manikarthikk done