search

microsoft / xdp-for-windows

XDP speeds up networking on Windows
MIT License
371 stars 41 forks source link

Use UndockedOfficial Parameter #632

Closed nibanks closed 2 months ago

nibanks commented 3 months ago

Official builds in OneBranch already pass -p:UndockedOfficial=true, so to simplify/eliminate any custom msbuild args that need to be passed for the builds there, we update the project files to key off this to do what is necessary for the SignMode and IsAdmin parameters.

mtfriesen commented 3 months ago

I don't understand why we would do this: XDP supports (to varying degrees) four different build systems today, and has supported three other ones historically, for a total of seven build systems. It is not sustainable or good design for XDP to take a dependency on a vague and variable flag like "UndockOfficial" when a clear, concise, and invariant flag like "IsAdmin" is available and already implemented. To switch to a flag that conflates or implies several other flags (all of which may change in the future) seems like a step backwards for no tangible gain.

mtfriesen commented 2 months ago

Closing for now, as we are keeping this logic in the undocked repo for now. We can reevaluate as needed.