search

microsoft / xdp-for-windows

XDP speeds up networking on Windows
MIT License
364 stars 41 forks source link

revert to vs artifacts format from windows #634

Closed mtfriesen closed 1 month ago

mtfriesen commented 1 month ago

Progress towards #633

nibanks commented 1 month ago

Why VS format? IMO, this is going in the wrong direction. The undocked props is going to undo this change.

mtfriesen commented 1 month ago

Why VS format? IMO, this is going in the wrong direction. The undocked props is going to undo this change.

let's take offline, but fundamentally the msbuild system cannot speak or be taught Windows; it must use x64 and release. This is quite clearly the VS standard, and should be the standard used within OSS projects.

The appropriate layer to convert to Windows artifacts is just prior to ingestion to Windows, if such ingestion occurs. Otherwise, there will be endless conversion to and from VS/Windows naming conventions, which is 100% avoidable.

it's easy to make output directories configurable, BTW, so there's no need to impose one standard or another onto shared projects: https://github.com/microsoft/xdp-for-windows/blob/3ff3d960b48c1156908ed1c7e1990d61bdff24f3/test/functional/taef/xdpfunctionaltests.vcxproj#L84