Small series of bug fixes - Githubissues

microsoft / xunit-performance

Provides extensions over xUnit to author performance tests.

MIT License

188 stars 55 forks source link

Small series of bug fixes #246

Closed jorive closed 6 years ago

jorive commented 6 years ago

Remove an extra ; from the <TargetFrameworks> on the simpleharness.csproj file.
xUnit micro-benchmarks harness: Call GC.Collect once more right after GC.WaitForPendingFinalizers
Added more docstrings to public apis
Updated the default Etw kernel/user providers, and remove duplication
Minor changes in the xUnit Api tests verbosity
Handle parsing $CLRHELPERS$ methods generated by the Jit on x86
Handle reloading unloaded modules

What is missing here?

Implementation is complete and correct, but performance is not the best, it can be improved.

jorive commented 6 years ago

@AndyAyersMS I agree, and I also wanted to revisit the flags we capture and we use, so I could remove the unnecessary ones to reduce the runtime overhead and generated file size. We were capturing a lot of data we were not parsing/using.