search

microsoft / xunit-performance

Provides extensions over xUnit to author performance tests.
MIT License
188 stars 55 forks source link

Update xunit version to 2.4 and target NS2.0 #269

Closed ViktorHofer closed 6 years ago

ViktorHofer commented 6 years ago

cc @jorive

jorive commented 6 years ago

@ViktorHofer there are some build failures.

ViktorHofer commented 6 years ago

Builders might be though to resolve as it conflicts with the CommandLineParser package which has beta dependencies...

jorive commented 6 years ago

Can it be fixed by specifying the package version on the test projects (use System.Resources.ResourceManager 4.3.0)?

ViktorHofer commented 6 years ago

I'm not sure, I don't think so as the dependency is pulled in by CommandLineParser. But I will quickly fork it and retarget it to NS2.0 and send a PR to them. Isn't much work.

ViktorHofer commented 6 years ago

Port done here: https://github.com/commandlineparser/commandline/pull/307

ViktorHofer commented 6 years ago

Till my PR gets merged in the commandlineparser repo I uploaded the temporarily locally built package to nuget and referenced it here to unblock further work.

jorive commented 6 years ago

Is this package in myget?

ViktorHofer commented 6 years ago

nuget :)

ViktorHofer commented 6 years ago

@dotnet-bot test this please

ViktorHofer commented 6 years ago

To be honest, I've no idea why the other two tests are failing / why xunit.runner.utility.netstandard20.dll can't be loaded...

ViktorHofer commented 6 years ago

Tests failed because of https://github.com/xunit/xunit/issues/1594#issuecomment-352911634. It seems this was never fixed. Adding netcoreapp2.0 and net461 tfms resolves the right assembly.

jorive commented 6 years ago

Yes, this is how xunit is packaged :(