exported CMakeLists.txt problems - Githubissues

microsoft / yardl

Tooling for streaming instrument data

https://microsoft.github.io/yardl/

MIT License

29 stars 5 forks source link

exported CMakeLists.txt problems #104

Open KrisThielemans opened 7 months ago

KrisThielemans commented 7 months ago

should set CMAKE_CXX_STANDARD (what's the current minimum?)
should set target_include_directories
do we really need to depend on the C HDF5 libraries ?

why is this code here, and if it's needed, why is it before the find_package(HDF5)? (it'll be overwritten, no?)

if(VCPKG_TARGET_TRIPLET)
set(HDF5_CXX_LIBRARIES hdf5::hdf5_cpp-shared)
else()
set(HDF5_CXX_LIBRARIES hdf5::hdf5_cpp)
endif()