exported CMakeLists.txt problems

[KrisThielemans]

• should set CMAKE_CXX_STANDARD (what's the current minimum?)
• should set target_include_directories
• do we really need to depend on the C HDF5 libraries ?
• why is this code here, and if it's needed, why is it before the find_package(HDF5)? (it'll be overwritten, no?)

  if(VCPKG_TARGET_TRIPLET)
  set(HDF5_CXX_LIBRARIES hdf5::hdf5_cpp-shared)
  else()
  set(HDF5_CXX_LIBRARIES hdf5::hdf5_cpp)
  endif()

[yassirnajmaoui]

I have the same problem.

HDF5 is not a requirement in our project, yet I get this error message:

CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find HDF5: (Required is at least version "1.10.5") (found
  HDF5_hdf5_LIBRARY-NOTFOUND;HDF5_hdf5_cpp_LIBRARY-NOTFOUND;HDF5_hdf5_LIBRARY-NOTFOUND)
Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.28/Modules/FindHDF5.cmake:1025 (find_package_handle_standard_args)
  generated/CMakeLists.txt:19 (find_package)

-- Configuring incomplete, errors occurred!

[KrisThielemans]

@yassirnajmaoui this is actually a different issue. You are asking if it's possible to exclude HDF5 from the compilation (ideally with a CMake option), while the above is on what should be in the CMakeLists.txt when using HDF5. @naegelejd @johnstairs possibly move @yassirnajmaoui's comment to a new issue?

[KrisThielemans]

In fact, there's #105 already!