search

microsoftarchive / Learn-LTI

Access the Microsoft Learn http://docs.microsoft.com/learn Catalog of Learning Paths and Modules directly from your Learning Management Systems using the Microsoft Learn LTI application
https://microsoft.github.io/Learn-LTI/
MIT License
126 stars 50 forks source link

Adding OAuth Audience field for Brightspace D2L support #156

Closed alphaz18 closed 2 years ago

alphaz18 commented 3 years ago

Adding customizable Audience field to be passed around for token. Originally, the aud claim in the token was automatically set to the tokenEndpointUrl. However, per (https://www.imsglobal.org/spec/security/v1p0) the audience claim MAY be the token endpoint url but is not necessarily that. Some lms platforms set a different aud claim, and thus would fail using LTI-Learn. Eg. Brightspace.

I made the field optional, so as to hopefully not break existing deployments, if blank, it should use the token endpoint as per previous. I haven't tested on Moodle, canvas or blackboard since I don't those platforms, only Brightspace with LTI 1.3.

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

leestott commented 3 years ago

@alphaz18 thanks for PR regarding the outh support for Brightspace D2L #156

Could you also help us develop setup/config guides for D2L and PR changes for https://github.com/microsoft/Learn-LTI/blob/main/docs/CONFIGURATION_GUIDE.md to include D2L see https://github.com/microsoft/Learn-LTI/issues/68

alphaz18 commented 3 years ago

@leestott Hi, I just pushed changes to the PR for the guide as requested, Hopefully that helps, Regards,

leestott commented 2 years ago

@alphaz18 his could you please take a look at the most recent changes for Openedx support and redo your PR based on the new additions

Conflicting files backend/Bindings/Edna.Bindings.LtiAdvantage/Services/NrpsClient.cs backend/Functions/Edna.Users/Edna.Users/UsersApi.cs

alphaz18 commented 2 years ago

i updated the pr, can you please get this merged its been sitting here for months with no activity. thanks.