microsoftarchive / Learn-LTI

Access the Microsoft Learn http://docs.microsoft.com/learn Catalog of Learning Paths and Modules directly from your Learning Management Systems using the Microsoft Learn LTI application
https://microsoft.github.io/Learn-LTI/
MIT License
126 stars 50 forks source link

Deploy script should prompt to run cleanup if there is an existing resource #192

Open warrenbuhler opened 2 years ago

warrenbuhler commented 2 years ago

Is your feature request related to a problem? Please describe. If you are deploying the LTI several times using the deploy script or running it again after the failed deploy, you need to remember to run the cleanup script between each run. If you don't, the script will fail.

Describe the solution you'd like The deploy script should determine if there are resources that need to be cleaned up, and if so -- prompt if you want to clean the resources up (at which point it automatically runs cleanup for you) and will exit if you say no.

*Describe alternatives you've considered It could automatically clean up existing resources without prompting, but that risks accidentally getting rid of work that people forgot about or another member of a team has done.

Additional context This is most relevant when setting up new installations from scratch, particularily if you run into issues.

leestott commented 2 years ago

@warrenbuhler This is an excellent proposal we would welcome this PR

@maitreeleekha @neha-dahiya