RecyclerView inside ViewPager

microsoftarchive / android-sliding-layer-lib

Highly customizable SlidingLayer as you have seen in Wunderlist

http://wunderlist.com

Apache License 2.0

932 stars 279 forks source link

Closed chiragagrawal-tudip closed 6 years ago

chiragagrawal-tudip commented 6 years ago

Used recyclerview inside viewpager and viewpager is inside the slider. But the issue we are getting from this library is that when we scroll up recyclerview, slider gets stuck in between.
So we have done some changes to solve it in SlidingLayer file.
I have tested my changes with your library and it's working fine. That is not disturbed by my code.
With that, my issue has also been resolved.

chiragagrawal-tudip commented 6 years ago

Removed previous changes.
I have implemented a method 'canScrollToView()' in which I have just added the return expression of 'canScroll()' which is holding the original return boolean value.
It will not affect the library at all.
I am overriding the 'canScrollToView()' method in the custom slider that we are using in the project as required by using the 'view' and 'dy' of method 'canScroll()'.
I have raised another PR (https://github.com/wunderlist/android-sliding-layer-lib/pull/112) and closing this PR.

chiragagrawal-tudip commented 6 years ago