Recyclerview inside slidinglayer

[chiragagrawal-tudip]

• Removed previous changes.
• I have implemented a method 'canScrollToView()' in which I have just added the return expression of 'canScroll()' which is holding the original return boolean value.
• It will not affect the library at all.
• I am overriding the 'canScrollToView()' method in the custom slider that we are using in the project as required by using the 'view' and 'dy' of method 'canScroll()'.

[chiragagrawal-tudip]

Hi @JlUgia, Please have a look at this PR.

[chiragagrawal-tudip]

Hi @JlUgia, Any update on this PR.

[JlUgia]

Hey @chiragagrawal-tudip! That'd would technically work, but it'd collide with the class structure. The method canScroll was intentionally used and exposed as a protected method so that further child classed in the hierarchy could follow this same standard that you can see in other views like the ViewPager. What I'd recommend is that you subclass the SlidingLayer and override the canScroll method similar to how you have done already.

That wouldn't require any change to this lib; and this change does not necessarily add anything to it. Nonetheless, I leave @CesarValiente and @aconsuegra in CC in case they have a different view on things.

Let me know if any further explanation would help.

[chiragagrawal-tudip]

Hi @JlUgia, Thank you for your valuable suggestion. I have achieved the same in my code. Thanks!

[JlUgia]

💃 🎉