search

microsoftarchive / android-sliding-layer-lib

Highly customizable SlidingLayer as you have seen in Wunderlist
http://wunderlist.com
Apache License 2.0
932 stars 279 forks source link

[BUG] Sliding layer does not fully disappear when layer is in small width or height #37

Open gebing opened 11 years ago

gebing commented 11 years ago

Sliding layer does not fully disappear when calling closeLayer(true). This will occur when sliding layer's layout is in small width or height.

I checked the code, and found it is caused by computeScroll() has not been called again when mScroller is reaching to its final position but not the final position.

Eg. i have a sliding layer with height 200, when i closed the sliding layer, and it will call smoothScrollTo(0, 200), and computeScroll() will stop to be called when mScroller's current position reach to 198. So the layer will not scroll to the position 220, and will not totally disappear.

Further, i will make a pull request to fix this bug.

gebing commented 11 years ago

I make a pull request #38 to fix this bug.