search

microsoftarchive / android-sliding-layer-lib

Highly customizable SlidingLayer as you have seen in Wunderlist
http://wunderlist.com
Apache License 2.0
931 stars 277 forks source link

Stickto right slider not fully opening #71

Open vincentsys opened 9 years ago

vincentsys commented 9 years ago

Just noticed that when using a sticked to the right sliding layer it never opens completely (check sample app for confirmation). After clicking open and the layer slided to the left you are always able to drag it a bit further to the left. This means on a "pixel-perfect layout" there will always be a little gap visible...

This does not happen on sticked to the left layers.

JlUgia commented 9 years ago

Hi vincentsys, thanks for your comment!

I'm not really sure about what you mean. The size of the layer depends on the width specified in the layout. If I try to reproduce the steps you mention I'm not able to slide the layer any further. A video or screenshot would help.

Thanks again, Jose L

vincentsys commented 9 years ago

Hi Jose,

it seems this effect is only visible on larger screens (tablets). Tested it wis a Galaxy Tab 10" and 7" (KitKat). On a Galaxy S5 (Lollipop) the effect was not visible. It may be tiny but unpleasent.

I've put a red layer of the same size (300dp) behind the sliding layer for better visibility. As mentioned above the red area is fully covered if setup for "stickto left". On the right side insted: If you open the sliding layer and slightly touch/slide it to the left it will move a view pixels. It might be purely screen size dependent as this effect is also visible using ADS virtual devices.

screenshot_2015-03-18-15-06-04

vincentsys commented 9 years ago

It also seems the same effect appears if stickto bottom ist used. Left and top are alright...

JlUgia commented 9 years ago

This is very helpful. We'll check that out. Do you want to give it a look as well?

vincentsys commented 9 years ago

I'll also take a look at it.

vincentsys commented 9 years ago

Havent't had the time to take a closer look but also noticed this: stick-to-top and stick-to-left: slider does not fully close stick-to-bottom and stick-to-right: slider does not fully open

(as mentioned above noticable on larger screens/tablets)

JlUgia commented 9 years ago

That's valuable information. Thanks @vincentsys

JlUgia commented 9 years ago

Hi @vincentsys. This is issue should be fixed in upcoming version 1.2.0. Feel free to give it a test to see if it also fixes it in your case.

vincentsys commented 9 years ago

looks good on first short tests. Thanks!

JlUgia commented 9 years ago

Good! Thanks to you! This will be closed when further tests are done (either by you or anybody else) and results are acknowledged.