search

microsoftarchive / data-pipeline

Exploring the problem of high-scale data ingestion on Azure
MIT License
6 stars 4 forks source link

using Appveyor for continuous build #40

Closed bennage closed 9 years ago

bennage commented 9 years ago

details about the service are here http://www.appveyor.com/ @lbrader you might be interested in this. @mj1856 can you give this a quick look over?

azurecla commented 9 years ago

Hi @bennage, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (christb). If you're full-time, we DON'T require a contribution license agreement. 

<p>
    If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.
</p>

TTYL, AZPRBOT;

bennage commented 9 years ago

Notice that the build status of this pull request is included. :smiley:

mattjohnsonpint commented 9 years ago

Hmmm.. I see in the build output none of the tests are running.

Skipping assembly (no tests match the specified filter).

I also see /trait "category=Unit", while in our code we have [Trait("Category", "Unit")]. Is it case-sensitive perhaps?

bennage commented 9 years ago

Blerg. The integration tests were failing before. When this passed, I assumed the tests were running.

bennage commented 9 years ago

It's not the case that causing the problem. I'm upgrading to xunit 2 to see if that changes anything.

bennage commented 9 years ago

Okay, I'm seeing passed tests now. I think that xunit 1.9.x was part of the problem. The traits are not consistently applied across the tests though (and there are a few odd tests). I'd like to work that out in a future pr. Do you see any other problems?

mattjohnsonpint commented 9 years ago

LGTM