search

microsoftarchive / iot-journey

a guidance project for implementing an IoT solution on Azure
Other
89 stars 34 forks source link

fixes static analysis issues. #290

Closed francischeung closed 9 years ago

francischeung commented 9 years ago

Connects to #243

bennage commented 9 years ago

Were you expecting this to pass or fail in CI?

francischeung commented 9 years ago

This first test should pass. I just added the internal ruleset to a project. Next commit will force code analysis on build.

francischeung commented 9 years ago

I've updated the projects in the ScenarioSimulator solution to use the custom ruleset file. The other 3 solutions need to be updated.

IotJourney.ruleset: CA1305 is a "Warning". If you change it to "Error", the build will break, as expected.

bennage commented 9 years ago

Hmm... I suspect that you'll need a NuGet package to trigger the build task. Some options are:

I'm particularly curious about the Rosyln one.