Fix for rare crash when using bgsave

microsoftarchive / redis

Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes

http://redis.io

Other

20.84k stars 5.38k forks source link

Fix for rare crash when using bgsave #472

Closed Harachie closed 7 years ago

Harachie commented 8 years ago

Fixed crash when trying to read memory outside of the allowed bounds.

ghost commented 8 years ago

Hi @Harachie, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSOTBOT;

taliesins commented 7 years ago

@Harachie did this ever get merged? We have been experiencing this same issue.

Looking at release notes they mention: "[Fix] Possible AV during background save." Is this related?

Harachie commented 7 years ago

Hi @taliesins , it was part of th x.x.502 merge as far as I know:

--[ Redis on Windows 3.0.502 ] Release date: Jun 21 2016

[PR] Fixed pointer overflow crash when using bgsave under rare circumstances. (by @Harachie)

Kind regards

taliesins commented 7 years ago

Do you want to close this PR then?