microsoftconnect / ms-intune-app-sdk-android

Intune App SDK for Android enables data protection features and mobile app management via Microsoft Intune
45 stars 18 forks source link

MAMEnrollmentManager.getRegisteredAccountStatus() deprecated without notes #154

Closed ZacSweers closed 1 year ago

ZacSweers commented 1 year ago

Describe the bug: This method was deprecated but is undocumented and has no instructions in the release notes.

In decompiled bytecode, it just calls through to a new overload with an extra (undocumented) string parameter with a null value.

image

However, this appears to break that method's contract as the parameter is annotated as @NonNull and emits a warning. As such, we cannot call it from Kotlin with a null value either and are left using the deprecated call.

I see the message refers to an OID, but it's not clear what that is.

To Reproduce N/A

Expected behavior: I would expect deprecations to have documented replacements/migrations.

Screenshots and logs: N/A

Smartphone (please complete the following information): N/A

Intune App SDK for Android (please complete the following information):

Additional context: Add any other context about the problem here.

microsoftjoe commented 1 year ago

Hi Zac, you are correct that there was a miss in the documentation for these methods. Sorry about that. The MAM integration guide will be updated in the next release. In the meantime, you should use the new methods, passing the same value for "aadId" that you used when you originally registered the account. "OID" is a more technically correct term for what we have been calling "aadId", sorry for any confusion about that.