microsoftgraph / aspnetcore-connect-sample

[ARCHIVED] This ASP.NET Core MVC sample shows how to connect to Microsoft Graph using delegated permissions and the Azure AD v2.0 (MSAL) endpoint.
MIT License
123 stars 96 forks source link

Has this been outdated by "AddMicrosoftAccount" in the auth pipeline? #19

Closed Sharor closed 6 years ago

Sharor commented 6 years ago

I came upon this https://docs.microsoft.com/en-us/aspnet/core/security/authentication/social/microsoft-logins?view=aspnetcore-2.1&tabs=aspnetcore2x

According to the docs it allows you to sign in with either work, personal or school microsoft account 🙂

I assume the "AzureAD" and custom Auth builder can be setup through this in a more general way or is there something I'm missing? 😉

mark-szabo commented 6 years ago

As far as I see this works with personal Microsoft Accounts only and not with work or school accounts. After a short scan, my understanding is that this library was created to have an easy way to integrate Microsoft account login when using other social identity providers (Facebook, Google). So if you are using AzureAD login and no other identity provider, I'd stick with the normal MSAL implementation seen in this sample.

Sharor commented 6 years ago

Thank you @mark-szabo, that's what I figured but I could not see through it 😉

Also your example here has served me very well for a couple of months, good stuff!

mark-szabo commented 6 years ago

I'm glad I was able to help! :)