microsoftgraph / microsoft-graph-comms-samples

Microsoft Graph Communications Samples
MIT License
208 stars 231 forks source link

max video sockets increase #307

Open doucheface1 opened 4 years ago

doucheface1 commented 4 years ago

is there a way to record more than 10 video sessions?

if we do a conference of more than 9 participants they dont record

we have set SampleConstants.NumberOfMultiviewSockets to 9 which is the limit

but need to know if this can be set to 250 which is video limit in teams

1fabi0 commented 4 years ago

Update your Microsoft.Skype.Bots.Media to the newest version you will be able to receive up to 50 concurrent video streams but remind video decoding completly runs on CPU

doucheface1 commented 4 years ago

yes but this doesnt help being out of sync? on a two way video call its out of sync when we take raw audio and video and use ffmpeg to join together.

doucheface1 commented 4 years ago

sorry answering wrong question here

Christian-Abbott commented 4 years ago

Which version of Microsoft.Skype.Bots.Media has the higher number of Concurrent videos? We are currently using 1.19.2.25-Aplpa but if we try to increase the max number of sockets it throws an exception.

1fabi0 commented 4 years ago

In the changelog to the newest version in nuget it says it's updated to up to 50 concurrent streams to update activate preview of nuget packages and install the latest version probabbly you need to update some more packages to a newer version like graph communication

Christian-Abbott commented 4 years ago

I have updated all nuget packages to the latest version and cannot see any newer version of Microsoft.Skype.Bots.Media above 1.19.0.25-Alpha, can you point me to the change log? Thanks

1fabi0 commented 4 years ago

You have to activate preview of nuget packages https://docs.microsoft.com/de-de/nuget/create-packages/prerelease-packages#installing-and-updating-pre-release-packages after update Skype bot Media the change log will open

ssulzer commented 4 years ago

Within a single bot call media session, there is still a limit of 10 primary/main video VideoSockets + 1 VideoSocket for screen sharing. The note in the readme change log refers to something else, a process-wide limit across all active bot calls.

1fabi0 commented 4 years ago

Then send more instances of a call Handler the limit is per application in the call

stefan2410 commented 4 years ago

@1fabi0 @ssulzer There is not newest version of Microsoft.Skype.Bots.Media above 1.19.0.25-Alpha, even in prerelease