search

microsoftgraph / microsoft-graph-comms-samples

Microsoft Graph Communications Samples
MIT License
209 stars 233 forks source link

[BUG?!] PAuse/Resume call recordings #333

Open andir78 opened 4 years ago

andir78 commented 4 years ago

Describe the issue OnAudioMediaReceived event handler is receiving events regardless of the call recording status. Therefore, in the limited testing I have performe, I've paused and resumed the recording and can see this reflected on recording status banner within the desktop app.

Code Snippet N/A

Expected behavior I would expect that the OnAudioMediaReceived event handler to not be receiving events until the recording status of the call is set to Recording. Otherwise (I assume) that I'll have to manage the event handler delegate setup/tear down, i.e. audioSocket.AudioMediaReceived -= OnAudioMediaReceived; / audioSocket.AudioMediaReceived += OnAudioMediaReceived; when updating the recording status...........which (to me at least) seems cumbersome. Admittedly this may be 'by design' I have misunderstood......any direction would be greatly appreicated.

bijaykush commented 3 years ago

@1fabi0 @JasonTheDeveloper I am also looking to stop/start the incoming audio streams. Call Recording Status only update the message on MS Teams Client Call UI banner message. Is there any way to that?

@andir78 Did you find any way to do this?

1fabi0 commented 3 years ago

Start and stopping audio streams is not possible but you can create your own bool to set if you want to handle audio, I think you could in theory also change the media session and disable there receiving audio, but you would have to try