search

microsoftgraph / microsoft-graph-comms-samples

Microsoft Graph Communications Samples
MIT License
203 stars 220 forks source link

Confusing configuration instructions on AksSamples/teams-recording-bot #439

Open simone-gaiarin opened 3 years ago

simone-gaiarin commented 3 years ago

Describe the issue Regarding the configuration for local debugging with ngrok.

The host.sh script is supposed generate a certificate for contoso.ngrok.io.

In the instructions in the .env file there is a setting AzureSettings__ServiceDnsName=contoso.ngrok.io that is then used to setup the MediaPlatformSettings field ServiceFqdn.

But how can this domain for which we generated a certificate then point at 1.tcp.ngrok.io:PORT?

It is not clear to me how can all this be accomplished without a custom domain and a CNAME entry, which would be quite handy, as explained in the other bot documentation (e.g. HueBot).

Are the instructions wrong or am I missing something?

dannygar commented 3 years ago

@simone-gaiarin, you've misunderstood the difference in setting up the SSL certificate required by a preview version of the Media SDK library, and the TCP tunnel configured and managed by ngrok.io. when you generate a SSL certificate for your ngrok subdomain (in the docs it is shown as contoso.ngrok.io), you enable SSL traffic between the Teams TCP media stream source and the tunneled endpoint in ngrok.io. At the end you'll get your Bot to listen to the TCP endpoint to receive media stream buffer.