microsoftgraph / microsoft-graph-comms-samples

Microsoft Graph Communications Samples
MIT License
204 stars 221 forks source link

Bot webhook data `callChainId` no longer persists on transfers #617

Open d3v1ngt0n0123 opened 1 year ago

d3v1ngt0n0123 commented 1 year ago

Describe the issue Recently (around 2022-01-05) the json data we receive on our bot webhook has changed. A call flow such as:

Now when transferring the resourceData.callChainId is different and we get resourceData.incomingContext.transferor instead

Expected behavior We would expect the resourceData.callChainId to persist across a transfer, is this not the purpose of that id?

Graph SDK (please complete the following information): Not an SDK issue, this the bot webhook configured in Azure.

Additional context Is this the intended behaviour now? If so is there anywhere we can subscribe to future changes as this is a breaking change. Also please let me know if there is a more appropriate place to log this issue, it is not clear where this should be reported.

Many thanks!

kc343 commented 5 months ago

bumping this old post as I am also interested in figuring out how to track transferred calls. AFAIK, the bot currently isn't receiving call notifications about call transfers and the transferred to call doesn't contain information to link it to the call it was transferred from. The only information in the migrosoft.graph.commsNotifications for the new call is the user that initiated the transfer

InDieTasten commented 5 months ago

Is it insufficient to have "only" the transferor? I believe that field has been populated like this for a long time and it technically provides more information than just sharing the same call chain id does. What's the use case for knowing/sharing the initial call chain id?

kc343 commented 5 months ago

For many organizations that require teams recording for compliance reasons, I would imagine it to be a requirement to be able to be able to trace calls that were transferred to/transferred from. Also, this isn't a comparison of transferor vs call chain id. Both should be provided as more information is always better. Like with the previous poster, I'm not sure where the appropriate place is to post these questions/concerns.

InDieTasten commented 5 months ago

I think you've come to the right place.

Let me tag some official people.

@ssulzer @samarthasthana