search

microsoftgraph / microsoft-graph-devx-api

Services API for Graph Explorer
MIT License
87 stars 35 forks source link

Snippet generation needs to add support for multiple namespaces (Java) #325

Closed andrueastman closed 1 year ago

andrueastman commented 4 years ago

AB#6985

baywet commented 3 years ago

@andrueastman @zengin AFAIK the snippet generation doesn't add any import in Java or using in dotnet, is there anything that needs to be done at this point?

zengin commented 3 years ago

In C#, the assumption was that using namespace Microsoft.Graph is always added to the outer decoration. So the solution was to add fully qualified names for types outside Microsoft.Graph namespace.

I don't think the same approach works well with Java given that fully qualified names are really long.

For automated tools, like Raptor compilation tests, we can either import model and request namespaces for all subnamespaces or we can determine the necessary imports on the fly.

Subnamespace samples are not yet reenabled.

https://docs.microsoft.com/en-us/graph/api/callrecords-callrecord-get?view=graph-rest-1.0

I had this in my TODO list, but I created an issue as I haven't found time to get to it yet: https://github.com/microsoftgraph/msgraph-sdk-raptor/issues/137

ddyett commented 1 year ago

@ramsessanchez please update PR which addressed this and close.