search

microsoftgraph / microsoft-graph-explorer-v4

React/Redux version of Graph Explorer used to learn the Microsoft Graph Api
https://developer.microsoft.com/graph/graph-explorer
MIT License
212 stars 91 forks source link

Replace language headers with icons (instead of text , let's use the language icon) using Fluent UI icons. #1493

Closed ElinorW closed 1 year ago

ElinorW commented 2 years ago

@RabebOthmani I have a few questions/concerns about this issue.

  1. Would the tab only have the icons without the text? or would they be alongside each other?
  2. Also, some languages (e.g Objective-C) don't really have an official icon
  3. Objective-C and Go icons don't exist in the Fluent UI documentation. In this case, should we just leave the text?
RabebOthmani commented 2 years ago

Hi @ElinorW , 1/ the icons would replace the text so we save on space and make more beautiful. Let me know if you need me to share a screenshot from other documentation portals. 2/What's the process to request icons? Is that something we can do? If not, can we get approval to use the official language icon available online?

ElinorW commented 2 years ago

Hi @ElinorW , 1/ the icons would replace the text so we save on space and make more beautiful. Let me know if you need me to share a screenshot from other documentation portals. 2/What's the process to request icons? Is that something we can do? If not, can we get approval to use the official language icon available online?

Okay, thanks. I haven't seen any provisions on how one can request icons, their documentation doesn't provide that. Perhaps we may need to get in touch with someone from the team

bruceburge commented 2 years ago

Please do not do this, icons are not an effectively replacement for text description, having usability should likely trump "beauty" in a utility that is often needed for rapid prototyping and API exploration. I doubt most users want to have to attempt to figure out what each icon means, and its functionality.

adhiambovivian commented 2 years ago

Thank you @bruceburge for your feedback on this one. Tagging our PM, @RabebOthmani

adhiambovivian commented 2 years ago

+1 @bruceburge on this one. @RabebOthmani it's generally mentally tasking to figure out what icons mean. I have seen other tools use both text and icon which captures the best of both worlds image

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.