microsoftgraph / microsoft-graph-explorer-v4

React/Redux version of Graph Explorer used to learn the Microsoft Graph Api

https://developer.microsoft.com/graph/graph-explorer

MIT License

212 stars 92 forks source link

Tenant name does not appear when signing in as a guest user #1845

Closed darrelmiller closed 2 years ago

darrelmiller commented 2 years ago

Steps to reproduce

Access Graph explorer using tenanted URL e.g. https://developer.microsoft-tst.com/en-us/graph/graph-explorer?tenant=tavis.ca
Sign in as a guest user to the tenant

Expected

To see the tenant name in the header and in the user profile card.

Actual

ElinorW commented 2 years ago

Hey @darrelmiller, I am trying to reproduce this though I don't get an option to sign in as a guest user. How can I achieve this?

darrelmiller commented 2 years ago

@ElinorW You have to add the tenant query parameter to the URL e.g.

https://developer.microsoft-tst.com/en-us/graph/graph-explorer?tenant=tavis.ca

In order to test it you will need to go into a dev tenant and then add your microsoft account as a guest in that tenant. Then you specify the dev tenant domain name in the tenant query parameter and sign in as a guest user.

I had completely forgot that this feature had been implemented.

ElinorW commented 2 years ago

Got it, I have been able to reproduce this now.

So, the first time I ran this, it was blank for me too... then after testing again, I got some tenant information

could you try running it again and see if you'll get anything this time.

adhiambovivian commented 2 years ago

@ElinorW I noticed that sometimes it just takes a bit of time to load. I think this is worth investigating further

ElinorW commented 2 years ago

@adhiambovivian Could be because I have to make a separate network call to get tenant info... This info doesn't seem to be present on a user's account data

ghost commented 2 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

ddyett commented 2 years ago

@ElinorW is this really blocked or work we haven't gotten to yet.

ElinorW commented 2 years ago

@ddyett this isn't blocked, I have moved it to the backlog and part of the the August milestone

ElinorW commented 2 years ago

This is resolved. For the tenant value I had to use a tenant ID as opposed to the tenant name

https://user-images.githubusercontent.com/18407044/184650471-ca6dd384-f89e-49e3-b415-f2d48695fd47.mp4

ElinorW commented 2 years ago

This has been resolved also when with the use of a tenant name.