microsoftgraph / microsoft-graph-explorer-v4

React/Redux version of Graph Explorer used to learn the Microsoft Graph Api
https://developer.microsoft.com/graph/graph-explorer
MIT License
202 stars 84 forks source link

fix: remove the replacement of escape characters in json response formatting #3163

Closed musale closed 1 month ago

musale commented 1 month ago

Overview

Removes replacement of escaped characters in the stringified json. closes #3158

Testing Instructions

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net

thewahome commented 1 month ago

@musale have you confirmed this to work with Safari? Though done a long time back, the replacement code was supposed to fix this issue #895 .

If this change makes the replacement code unnecessary, then we might not need to stringify then parse. We can just pass the Json as is and get rid of this function

musale commented 1 month ago

Pinging @Onokaev to validate this on Safari.

SilasKenneth commented 1 month ago

Tested in Safari on iOS 17.5.1

———

IMG_0444

musale commented 1 month ago

Thank you @SilasKenneth! Also tested the paths in the #895 and they work as expected.

thewahome commented 1 month ago

@musale since the test works, the stringify -> parse is an unnecessary set of legacy steps. Is this something that we can confidently remove?

musale commented 1 month ago

@musale since the test works, the stringify -> parse is an unnecessary set of legacy steps. Is this something that we can confidently remove?

Sure! Unless that telemetry is important, I don't see the need for that function too.

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3163.centralus.azurestaticapps.net

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud