refactor: use strong types in authentication module

musale commented 1 month ago

Overview

Use strong types in src/modules/authentication. Closes #3187

Testing Instructions

open any files in src/modules/authentication
ensure no use of any types
ensure npm run test passes in src/modules/authentication without fails

Some stats

before

5 any counts in 2/10 files

AuthenticationWrapper.ts:4
msal-app.ts:1

after

authentication-error-hints.ts:0
AuthenticationWrapper.spec.ts:0
AuthenticationWrapper.ts:0
authUtils.spec.ts:0
authUtils.ts:0
ClaimsChallenge.ts:0
index.ts:0
interfaces/IAuthenticationWrapper.ts:0
interfaces/IClaimsChallenge.ts:0
msal-app.ts:0

ElinorW commented 1 month ago

This is really great! I suggest creating an issue under this main issue: https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues/2888 So that we can track the different areas being tackled