microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
943 stars 301 forks source link

[file-list] mgt-file-list should have spinner/Shimmer when loading content content when query changes #1068

Open aaclage opened 3 years ago

aaclage commented 3 years ago

Describe the bug As follow up from #954 also would like to recommend to have a loading when query is changed. Using the mgt-file-list control with dynamic queries there are some milliseconds "SharePoint Context" of loading, could be important to include a loading action for slower environments.

To Reproduce Steps to reproduce the behavior: Include "<FileList" with fileListQuery property that will be change during the applications such us "/me/drive/root/search(q='" + SearchQuery + "')"

This behavior can be seen in the following example when making a search in Drive Library: https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-onedrive-finder

Expected behavior When control has dynamic queries, control will refresh content to display, the loading of content could be slower using different environment and no information regarding loading is displayed. Could create questions to User such us "If he already clicked?".

Screenshots Using graph Drive "search" parameter to find documents but no loading image

Mgt-file-list loading expectation between changing of queries image

Environment (please complete the following information):

ghost commented 3 years ago

Hello aaclage, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

nmetulev commented 3 years ago

I think this is a great feature request, I agree. We should update the file picker for the next release to support shimmer.

beth-panx commented 3 years ago

To investigate: Shimmer in Fluent UI @yyiinnggzz