microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
954 stars 306 forks source link

[BUG] mgt-person [retemplate metadata] - doesn't show person details when template is used with view = threelines #1328

Closed ParthasarathyRaja closed 3 years ago

ParthasarathyRaja commented 3 years ago

Describe the bug mgt-person doesn't show person details when template is used with view = threelines

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://mgt.dev/?path=/story/components-mgt-person-templating--retemplate-metadata'
  2. See the output shown in the example. The example itself is not showing the person details.

Expected behavior When template is used with view=threelines, mgt-person should show all person details included in the template

Screenshots image

Environment (please complete the following information):

Additional context This was working until 1st week of September 2021. We have been using this feature in our projects for more than 2 months. It stopped showing person details suddenly now.

ghost commented 3 years ago

Hello ParthasarathyRaja, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

vogtn commented 3 years ago

@Ramakrishnan24689

Thanks for the details, seems like there is an issue with templating with our latest version of mgt v2.3.0. I'm investigating at the moment, if you need you can point to the older v.2.2.1 where it seems to be working as expected: E.g: https://jsfiddle.net/nicolasjvogt/ua398dtj/7/

Additional examples not working for v2.3.0

    <mgt-person person-query="me" view="twoLines" inheritdetails>
      <template data-type="line1">
        <div>
          hi {{person.jobTitle}}
        </div>
      </template>
    </mgt-person>
Ramakrishnan24689 commented 3 years ago

@Ramakrishnan24689

Thanks for the details, seems like there is an issue with templating with our latest version of mgt v2.3.0. I'm investigating at the moment, if you need you can point to the older v.2.2.1 where it seems to be working as expected: E.g: https://jsfiddle.net/nicolasjvogt/ua398dtj/7/

Additional examples not working for v2.3.0

    <mgt-person person-query="me" view="twoLines" inheritdetails>
      <template data-type="line1">
        <div>
          hi {{person.jobTitle}}
        </div>
      </template>
    </mgt-person>

I think I am wrongly mentioned here. @ParthasarathyRaja FYI...

beth-panx commented 3 years ago

@ParthasarathyRaja as FYI

@vogtn change was made in this commit when person in the template is renamed to personProperties. So developers will need to access displayName and other properties like personProperties.displayName. We should fix this. :D