[BUG] Fluent upgrade master issue

[vogtn]

Describe the bug Collection of issues we are working on or handing off to fluent for further investigation

Categorized issues

Uncategorized issues

Custom templating

I'm having a challenge working on templates for the generic picker. These lines microsoft-graph-toolkit/mgt-picker.ts at bethpan/picker · microsoftgraph/microsoft-graph-toolkit (github.com) should work :grinning: with closed eyes but:

The custom template is rendered and displayed below the picker by default. When I get no results, the custom template is not shown.

I'm not sure what I might be missing.

<mgt-picker entity-types="channels,people" max-results="2,5">
  <template data-type="error-people"> <p>No poeplr are hiyaaa</p> </template>
</mgt-picker>

Custom Events

I'm implementing a custom selectionChanged event. I would this to be triggered when you select an item or remove it from a selection. For setting it when an item is selected works. When deselecting, I have set up a function https://github.com/microsoftgraph/microsoft-graph-toolkit/blob/bethpan/picker/packages/mgt-components/src/components/mgt-picker/mgt-picker.ts#L38 which is called whenever the pickeriteminvoked event is emitted. This event is emitted in the Fast fast-picker-list-item component https://github.com/microsoft/fast/blob/master/packages/web-components/fast-foundation/src/picker/picker-list-item.ts#L78-L80. At the time of it being triggered, I have access to the value which is either:

• person-e3d0513b-449e-4198-ba6f-bd97ae7cae8
• channel-HR Taskforce- General

So for people, I can easily strip out the person- part and get the id which I can use to get the person details and purge it from the selectedPeople selection.

As for the channels, I will only get the team and channel name. The challenge here is, do I go ahead and implement a way to get the channel using the team name and channel name OR there's a better way?

Also, I haven't checked what the Chats API or implementation will end up to but I feel like I need an elegant way to do this.

[ghost]

Hello vogtn, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

[vogtn]

MGT Component: Teams-channel-picker Fast/Fluent Component: Combobox + Treeview Issue: The Combobox selection flyout should be able to support the treeview lists to support our use case for teams and channels. Sample implementation:

[vogtn]

MGT Component: Teams-channel-picker Fast/Fluent Component: Combobox + Treeview Issue: The Combobox input area should be able to support multiselect.

Result: Multiple selection mode is currently in review for and (the spec for doesn't support multi-select). Here's the PR for multiselect (still in progress): https://github.com/microsoft/fast/pull/4974

[vogtn]

MGT Component: Agenda Fast/Fluent Component: Avatar Issue: Avatar web component creation

Result: waiting for: https://github.com/microsoft/fluentui/pull/20151

[vogtn]

MGT Component: person-card teams-channel-picker people-picker Fast/Fluent Component: Combobox Tree-view Issue: Treeview and combobox should support some sort of overflow, we have to support scrolling for fixed height containers.

Result: None yet, designs are in the works, for now we fallback to css.

[vogtn]

MGT Component: teams-channel-picker people-picker Fast/Fluent Component: TreeView Issue: Treeview should support disabling selection of the parent elements for our usecase of not selecting teams.

Result: Following this feature request: https://github.com/microsoft/fast/issues/5448