search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
944 stars 303 forks source link

Styling should allow more options than just CSS variables #1451

Open sebastienlevert opened 2 years ago

sebastienlevert commented 2 years ago

This is a work in progress and open for discussion

Proposal: Styling a MGT component should allow more flexibility than just CSS variables

Description

Styling is a big topic for MGT and we should have a better story for developers. Developers like our CSS variables but it's sometimes limiting. Developers would prefer to have a greater control over their styling, especially because of the "challenges" created by the Shadow DOM.

Rationale

Preferred Solution

This is still a work in progress, but here are a couple of areas we think we could explorer :

ghost commented 2 years ago

Hello sebastienlevert, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

gavinbarron commented 2 years ago

Browser support for ::part() is pretty good now, https://caniuse.com/?search=%3A%3Apart , and probably the best way we have outside of more CSS variables.

sebastienlevert commented 2 years ago

It would be a great way to offer customization!

gavinbarron commented 1 year ago

I suggest that we develop a spec per component to define the parts that we want to expose to move this forward