search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
924 stars 287 forks source link

Add localizations to Person Card #1481

Open thomaswidmer opened 2 years ago

thomaswidmer commented 2 years ago

Proposal: Add localizations to Person Card

Description

Currently the Person Card only displays titles and other default text in English. While the documentation shows that translations can be integrated, the Toolkit that we use with PnP Modern Search Webpart does not show any translations (at least in German language).

Rationale

Features of the Microsoft Graph Toolkit can be accessed by a broad community when using the Pnp Modern Search Webparts (without the need to develop a custom solution). You just get the Webparts, install and use them. That makes it simple to distribute the Toolkit Features to people speaking many different languages. Additionaly, a standardized set of translations absolutely makes sense.

Preferred Solution

Integrated localization as one can see in the Playground (https://mgt.dev/?path=/docs/components-mgt-person-card--localization) while using a standardized set of translations.

Additional Context

As Mikael Svenson commented in this post, the Toolkit misses translations: https://github.com/microsoft-search/pnp-modern-search/discussions/1714

At the moment, the card renders something like this: image

ghost commented 2 years ago

Hello thomaswidmer, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

sebastienlevert commented 2 years ago

Thanks for the suggestion! I believe this is something we could need your help with! Would you be willing to provide the translations you'd be using for this? We will be looking a way to provide the right language based on the browser locale. But as you'd imagine, we don't have the resources to build every languages! Your help would be super appreciated! Let us know if this is something you can help with!

thomaswidmer commented 2 years ago

Yes, I could provide at least German translations. No problem if not every language is built from start. I am sure there will be need for other translations from our clients in the next months/years. So I'll also have resources to translate those languages.

sebastienlevert commented 11 months ago

Related to #1712. We should provide default languages (thanks to the community) and load the appropriate language (if configured this way).