microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
964 stars 309 forks source link

Use MGT in SharePoint tenants with and without the mgt-spfx library package installed #1765

Closed MarksPoint closed 1 year ago

MarksPoint commented 2 years ago

We have the following situation:

How would we go about building our solution in such a way that it uses the mgt-spfx library package when it's installed, but uses the bundled mgt-react library otherwise?

Please note that updating our solution to always use the mgt-spfx library isn't feasible since we'd have to update > 100 installations done by many different parties.

ghost commented 2 years ago

Hello MarksPoint, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

sebastienlevert commented 2 years ago

Thanks @MarksPoint for the issue. We have been investigating and this would be part of our v3 milestone (later this year). We want to provide more granularity in the names of the components to potentially avoid the mgt-spfx package. For now, the request would be to use mgt-spfx as the supported option for SPFx development to avoid collisions.

Thanks!

gavinbarron commented 2 years ago

Adding an additional point on mgt-spfx this solution requires that all customizations built using mgt use mgt-spfx. Otherwise, there are still going to be multiple attempts to register the custom element.

sebastienlevert commented 1 year ago

This will be supported as part of our v3 release. It was already merged in out next/fluentui branch if you want to take a look. The only requirement will be to utilize v3 and stop using v2 for this use case.