microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒

https://docs.microsoft.com/graph/toolkit/overview

Other

924 stars 287 forks source link

mgt-person-card-organization #2012

Open mohamedcherifmo opened 1 year ago

mohamedcherifmo commented 1 year ago

Proposal: Support mgt-person-card-organization as its own component

Description

Currently the person card displays the org chart but there's no way to show it separately, however i think it would be a great feature to provide it as its own component

Rationale

A lot of times you want to show the org chart on its own, or for a specific department rather than based on a person card.

Preferred Solution

expose mgt-person-card-organization such that it can be used in a similar way to that of person-card, ex.

ghost commented 1 year ago

Hello mohamedcherifmo, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

musale commented 1 year ago

Hello @mohamedcherifmo thank you for raising this issue. We have been making updates to the components for version 3 of mgt. One of the updates that we have is making some of the parts of a huge component their own individual component. Some of the reasons for doing this you have already raised for your case. We shall be shipping this in our upcoming v3. Have a look at this PR https://github.com/microsoftgraph/microsoft-graph-toolkit/pull/1958 in review by @Mnickii and feel free to add your suggestions for this kind of features.

mohamedcherifmo commented 1 year ago

I didn't understand from this PR how they would be separated, also would it then give me the ability to define / customize the sections in the person card? (Through templating maybe?)

gavinbarron commented 1 year ago

let's try and keep this issue focused on the topic of making a separate mgt-person-organization component and keep the discussion on wider implications/usage other components in the person-card over on PR #1958 please.

Regarding the idea of mgt-person-organization for developers to use in their own code, we will ship one in a v3 release, the only question if it's part of 3.0.0 or a later release.

sebastienlevert commented 1 year ago

If we were to ship a simple mgt-person-organization component, what would be the different settings / knobs / configuration you'd expect to be able to modify to have a great developer / user experience?

mohamedcherifmo commented 1 year ago

The ones I have in mind are:

Person (id or query)
can go to manager or not (usually if we're going to display it for a department, we don't want someone to navigate above the department head)
Number if levels to show by default
ability to inherit (in case using it in a person section)

musale commented 1 year ago

I didn't understand from this PR how they would be separated, also would it then give me the ability to define / customize the sections in the person card? (Through templating maybe?)

For this release, you will not be able to customize it. I agree with @sebastienlevert that if we were to make a standalone mgt-person-organization component then it would be the perfect place to add the necessary customization.