search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
936 stars 296 forks source link

{Linked:Bug3408266}[BUG] Screen-reader does not announce the position/email of the People Picker suggestions #2143

Closed saahilchawande123 closed 1 year ago

saahilchawande123 commented 1 year ago

Describe the bug NVDA is not announcing the position or email of the people suggested in the People Picker. It is only announcing the name.

To Reproduce Steps to reproduce the behavior:

  1. Turn on NVDA using 'Ctrl +Alt + N' key
  2. Focus the screen reader on the MGT People Picker
  3. Type 'A' inside the edit field and suggestions appear.
  4. Now, navigate the search suggestions using arrow key.
  5. Observe that screen reader's announcement.

Expected behavior Screen reader also reads the position/email of the suggested contacts along with the name.

Screenshots

Screen reader is not announcing the complete information of the people with designation in the search suggestions list item inside the 'Delete User data' combo box

https://user-images.githubusercontent.com/116312427/226744522-aa4646a4-812b-4c17-b7a3-463c52c26ac4.mp4

Environment (please complete the following information):

Additional context The reason for what is being announced is because that is the value of the aria label on the li (line 948 from the provided link) of the list within the mgt people picker code. This is where the change would be needed to resolve what is being described in the bug. 

https://github.com/microsoftgraph/microsoft-graph-toolkit/blob/main/packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts#:~:text=aria%2Dlabel%3D%22%20%24%7Bthis.strings.suggestedContact%7D%20%24%7Bperson.displayName%7D%22 

ghost commented 1 year ago

Hello saahilchawande123, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

v-aman commented 1 year ago

Bug 3408266: [Viva Pulse-Manage Viva Pulse-Delete User data]: Screen reader is not announcing the complete information of the people with designation in the search suggestions list item inside the 'Delete User data' combo box.