search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
944 stars 302 forks source link

[BUG] mgt-file-list needs a zero results view #2154

Open gavinbarron opened 1 year ago

gavinbarron commented 1 year ago

Describe the bug When there are no items to display in a file list we should render a state that allows users to see that the query succeeded and returned no items

To Reproduce Go to https://mgt.dev/next/pr/2057/?path=/story/components-mgt-file-list-composite--use-grid-view Click on the attachments folder Not that nothing is rendered for the file list/grid

Expected behavior Suggest that we add a zero results rendering template (could be available as a named template for customization?) Should look something like this: image

ghost commented 1 year ago

Hello gavinbarron, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

musale commented 1 year ago

@gavinbarron should we have this for all components that render items? Linking https://github.com/microsoftgraph/microsoft-graph-toolkit/issues/395

sebastienlevert commented 1 year ago

Similar to how I added a renderError to the baseCOmponent with Search, we might want to do something similar with renderNoData and have a default template that could support a text and very large icon?

gavinbarron commented 1 year ago

Heck yeah @musale good thinking! And @sebastienlevert I like that idea.