microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
944 stars 303 forks source link

[`mgt-todo`] Allow editing of todos #2161

Closed gavinbarron closed 10 months ago

gavinbarron commented 1 year ago

Proposal: Add edit mode to mgt-todo

Description

Currently users of the mgt-todo component can only complete or uncomplete a todo item. A user should be able to edit all fields on the todo

Rationale

We want users to love this component, not having an edit mode feels like a miss

Preferred Solution

Design required to show an edit mode and a ui action to enter edit mode

ghost commented 1 year ago

Hello gavinbarron, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

gavinbarron commented 1 year ago

@yejuntak if you could please work on some designs for how to edit todo items inline

yejuntak commented 1 year ago
Screenshot 2023-07-20 at 12 44 44 PM

The design has been updated to the figma link. If you have any issue or questions please ping me on Teams.

https://www.figma.com/file/2uBa2lODCTSj1CZSI6USee/Microsoft-Graph-Toolkit?type=design&node-id=8068%3A141398&mode=design&t=Ayin4dc8b8Msqpxk-1

gavinbarron commented 1 year ago

Awesome, thanks @yejuntak, I've added some comments to the Figma file

sebastienlevert commented 1 year ago

Same here. I think we're onto something!

yejuntak commented 1 year ago

This has been updated and edited to our MGT figma file. Same link as above. Please take a look.

sebastienlevert commented 1 year ago

Reopening and adding in our Ready bucket to start implementation!