search

microsoftgraph / microsoft-graph-toolkit

Authentication Providers and UI components for Microsoft Graph 🦒
https://docs.microsoft.com/graph/toolkit/overview
Other
944 stars 302 forks source link

[MGTP-Left Navigation-Custom Properties]: Proper alt is not defined for the ‘Location’ icon under ‘Custom Properties’ page. #2235

Closed vagpt closed 1 year ago

vagpt commented 1 year ago

Test Environment:  OS Build: Windows 11  Version: 22H2 (OS Build 25300.1000)  Browser: Edge dev  Browser Version 114.0.1807.5 (Official build) dev (64-bit) URL: Components / mgt-agenda / Style - Custom Properties ⋅ Storybook User ID: V-id  Screen reader: Narrator   Repro Steps: 

  1. Open the above URL and login with valid credentials.
  2. Turn on 'Narrator' using 'Ctrl+ win+ enter' keys.
  3. The ‘Microsoft Graph Toolkit Playground' Overview page will be displayed. 
  4. Navigate to the 'Left rail navigation' region using tab key.
  5. Navigate to 'Custom Properties’ control and select it.
  6. The ‘Custom Properties’ page will open.
  7. Turn on the scan mode through Caps lock +Space key.
  8. Navigate to the image present under ‘Custom Properties’ page.
  9. Observe the screen reader announcement.

Actual Result: Proper alt is not defined for the image under ‘Custom Properties’ page. Screen reader announces 'Graphic' while navigating in scan mode.

Expected Result: Proper alt should be defined for the image under ‘Custom Properties’ page. Screen reader should announce something like as 'Location icon'.

Note:

  1. Same issue is repro throughout the 'Location icon' under Custom Properties’ page.
  2. Same issue is repro with NVDA screen reader.

User Experience: Screen reader users will get impacted as user will not be able to understand the purpose of the icon provided and will not be able to make proper track of the content.

Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)"

https://user-images.githubusercontent.com/95913748/236487190-8f9ba92c-5bf7-43e8-ba80-184034108956.mp4

ghost commented 1 year ago

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

Raisul123 commented 1 year ago

The issue has been fixed on web. Verified on below test Environment. Test Environment: OS Build: Windows 11 Version: 22H2 (OS Build 23466.1001) Browser: Edge dev URL: Components / mgt-agenda / Style - Custom CSS Properties ⋅ Storybook Browser Version 115.0.1866.1 (Official build) dev (64-bit) Screen Reader: Narrator

image